Discord Forum Board

Threadfinn2 weeks ago

The item id for water is: item.minecraft.potion.effect.water so I think this is intended since it's just a type of potion that has the water effect, and I don't think all potions are intended to count separately

Threadfinn2 weeks ago

Although they do show up differently in the inventory so maybe they should all be unique

PqvnOP2 weeks ago

It makes sense from a code perspective, but I think this is misleading to newer players unnecessarily especially since they appear like separate items unless you open tooltips

PqvnOP2 weeks ago

I think it would also be worth investigating different kinds of maps if it hasn't been talked about already

Pythoria2 weeks ago(edited)

Draftout ultimately isn't designed around inexperienced players

PqvnOP2 weeks ago

i don't think you should have to open up tooltips / know this quirk for a goal like this

Pythoria2 weeks ago

i agree it's misleading but at the same time if you change it then would you make every type of potion work differently? would thick potions count as potions or water bottles? where do you draw the line

Pythoria2 weeks ago

an id basis makes the most sense imo since its the most consistent to base it off

Pythoria2 weeks ago

if some things are different but some things arent then where do you draw the line

PqvnOP2 weeks ago(edited)

i think the potion portion of the metadata is a good way to differentiate: https://minecraft.wiki/w/Data_component_format/potion_contents
https://minecraft.wiki/w/Potion#Item_data
and i think a similar idea can be applied for maps (although it may not be as clear in this case):
https://minecraft.wiki/w/Map#Metadata

Pythoria2 weeks ago

im assuming you mean buried treasure maps and locator maps?

1

Threadfinn2 weeks ago

each potion is considered a unique item in the inventory, but so are suspicious stews, enchanted books, and others

Threadfinn2 weeks ago

But what about something like ominous bottles, which are stackable but different levels don't stack?

Threadfinn2 weeks ago

Should different levels of ominous bottle be different because the game won't let you stack them?

PqvnOP2 weeks ago

Potions have different names as opposed to suspicious stews and books

Threadfinn2 weeks ago

true, but I do think item id is probably the clearest separator, which is what it currently goes by

PqvnOP2 weeks ago

I don’t see why we can’t use a combination of item id and metadata

PqvnOP2 weeks ago

If implementation is too much of a hassle they can mark this as “won’t fix” or some equivalent

Threadfinn2 weeks ago

Because all the other examples have different metadata, and it's weird to only look at metadata for one specific item

PqvnOP2 weeks ago

I think a special case may be warranted here but I’ll leave that as a decision for the dev team

Threadfinn2 weeks ago

Yeah

Threadfinn2 weeks ago

You could maybe make a suggestion for it, since I think it's more of a choice than a bug

PqvnOP2 weeks ago(edited)

It’s a side effect of the implementation choice (I’m guessing) and we have all the necessary context here already so i think keeping it as a bug-report is ok

noura 🜛2 weeks ago

that's the translation string, the item id is just minecraft:potion for potions and water bottles

1

noura 🜛2 weeks ago

that'd be a pretty arbitrary design choice though. like why should the potion component allow them to count separately, but not any of the other components?

noura 🜛2 weeks ago

why shouldn't wooden swords with different durability values count separately if potions do

noura 🜛2 weeks ago

well this quirk gave us the easiest way to get the local brewery goal, so if it's a matter of game knowledge then i don't see why it's bad for players to learn about this

Merrick2 weeks ago

I think each type of potion should be unique personally. Something like enchanted books probably not, but unique potions makes sense to me

spicedspaghetti2 weeks ago

because they have the same name

spicedspaghetti2 weeks ago

unlike potions

violetneidon2 weeks ago

because potions exist separately in the creative menu

noura 🜛2 weeks ago

so should items renamed in an anvil count then?

noura 🜛2 weeks ago

all of this just proves the initial point clearly

noura 🜛2 weeks ago

you're opening a big can of worms if you decide what counts as a "Unique Item" arbitrarily

noura 🜛2 weeks ago

unique item ids is just the best way, even if it's unclear for players who play with f3+h disabled or don't know that water bottles are minecraft:potion

spicedspaghetti2 weeks ago

that argument makes no sense

spicedspaghetti2 weeks ago(edited)

"the mod isnt about speedrunning" is what rowl said

spicedspaghetti2 weeks ago(edited)

but most goals are being designed in a way that caters to speedrun knowledge imo

Pythoria2 weeks ago

how is like any of ts speedrun knowledge

Pythoria2 weeks ago

okay to be fair

Pythoria2 weeks ago

i dont speedrun

Pythoria2 weeks ago

but how is knowing that water bottles and potions and different kind of potions count as the same item speedrun knowledge?

Pythoria2 weeks ago

unless im misreading

spicedspaghetti2 weeks ago(edited)

well if you want to be competitive/speedrun a goal you would usually learn all niche things that might not make sense to a casual player

Pythoria2 weeks ago

at that point you're not talking about regular speedrunning or anything like that you're just talking about... learning?

Pythoria2 weeks ago

like

Pythoria2 weeks ago

fucking hell

Pythoria2 weeks ago

i get that it has a learning curve in that regard but

Pythoria2 weeks ago

alot of things in draftout are way more easily learnable from broad parts of the game and applicable to broad parts of the game compared to mcsr

Pythoria2 weeks ago

in a casual way

spicedspaghetti2 weeks ago

well this isn’t anything you would learn outside draftout

spicedspaghetti2 weeks ago

well yes obviously you learn minecraft items have ids

spicedspaghetti2 weeks ago

but if you asked a lot of people whether potions are unique items

spicedspaghetti2 weeks ago

they would say yes no?

violetneidon2 weeks ago

just going to repeat this

violetneidon2 weeks ago

casual players will understand unique items as "items you can grab from creative"

violetneidon2 weeks ago

or just items with different crafting recipes

spicedspaghetti2 weeks ago

I would narrow it down to vanilla item names but yeah

spicedspaghetti2 weeks ago

As enchanted books and sus stew shouldn’t be unique imo

violetneidon2 weeks ago

thats true

violetneidon2 weeks ago

enchanted books are always called "enchanted book" and functionally are just a single, enchanted item

violetneidon2 weeks ago

but potions have different names for effects, though not upgraded potions (level or duration)

noura 🜛2 weeks ago

i'm literally using your argument! potions should count separately bc they have different names (a different item_name component), so my sword "The Piss Blade" should count too

violetneidon2 weeks ago

afaik custrom item names are a different component?

violetneidon2 weeks ago

you could base it on unique localization names

spicedspaghetti2 weeks ago

custom_name is for the anvil yeah

spicedspaghetti2 weeks ago

but item_name doesn't seem to be the right one either

noura 🜛2 weeks ago(edited)

the potion component has a custom_name string field that potions use

noura 🜛2 weeks ago

separate from the minecraft:custom_name component

noura 🜛2 weeks ago

at least to me, this would be kind of a flimsy solution, like on what grounds does a translation string convey a "Unique Item" that the identifier doesn't already achieve by itself?

noura 🜛2 weeks ago

the id is also unchanged for different languages

noura 🜛2 weeks ago

don't you think that implies more, idk, concreteness?

PqvnOP2 weeks ago(edited)

I don’t appreciate you using the slippery slope argument to make a vanilla potion equivalent to a custom named item.

noura 🜛2 weeks ago

where is the slippery slope

noura 🜛2 weeks ago

it's YOUR argument

noura 🜛2 weeks ago

you don't actually have to appreciate me to understand what the point i'm making is, you just need like, a braincell

noura 🜛2 weeks ago

"different item names are not a solid enough meter to gauge uniqueness when it comes to items"

noura 🜛2 weeks ago

made it easy for you

noura 🜛2 weeks ago

what else do you want

noura 🜛2 weeks ago

i'm just gonna close this thread now because it's obviously not a bug. if you have anything to add, you're free to make a thread in #suggestions to request implementing this change

Water Bottle and Potions count as same item for "Fill Inventory with Unique Items"